Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethers does not get ENS domain addresses for coin type anymore #4081

Closed
zotakk4o opened this issue May 25, 2023 · 2 comments
Closed

Ethers does not get ENS domain addresses for coin type anymore #4081

zotakk4o opened this issue May 25, 2023 · 2 comments
Assignees
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6

Comments

@zotakk4o
Copy link

Ethers Version

6.4.0

Search Terms

ens, domain, address, resolve

Describe the Problem

The library can no longer retrieve an address from a given ENS domain and coin type. It always returns null. However, the supported coin types by the ENS can be found here https://github.com/satoshilabs/slips/blob/master/slip-0044.md.

From my investigation, the validity check for a given coinType is not implemented, thus all coin types passed to ensResolver.getAddress() are invalid and the result is always null.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

Ethereum (mainnet/ropsten/rinkeby/goerli), Altcoin - Please specify (e.g. Polygon), node.js (v12 or newer)

Environment (Other)

No response

@zotakk4o zotakk4o added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels May 25, 2023
@ricmoo
Copy link
Member

ricmoo commented Jun 2, 2023

There is a stub for the provider plugin, which I will fill in shortly. Thanks for the reminder. I'll get to this soon.

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. and removed investigate Under investigation and may be a bug. labels Jun 2, 2023
ricmoo added a commit that referenced this issue Jun 14, 2023
@ricmoo
Copy link
Member

ricmoo commented Jun 14, 2023

In v6.6.0 I've added support for:

  • any EVM-compatible chain can be resolved using ENSIP-11
  • for full coinType support, the ProviderPluginMulicoin is now available, when attached it will pull in the @ensdomains/address-encoder package and provide support for all coinTypes supported by that library

Try it out and let me know if there are any issues. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 14, 2023
@ricmoo ricmoo closed this as completed Jun 24, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Development

No branches or pull requests

2 participants