Why is hash optional in TransactionResponse? (typings)

[mrwillis]

I suspect this has to do with submitting a manual transaction vs submitting a transaction to the network as TransactionResponse inherits from Transaction. Is there ever a case where TransactionResponse wouldn't have a hash?

export interface TransactionResponse extends Transaction {
    blockNumber?: number;
    blockHash?: string;
    timestamp?: number;
    confirmations: number;
    from: string;
    raw?: string;
    wait: (confirmations?: number) => Promise<TransactionReceipt>;
}
export interface Transaction {
    hash?: string;
    to?: string;
    from?: string;
    nonce: number;
    gasLimit: BigNumber;
    gasPrice: BigNumber;
    data: string;
    value: BigNumber;
    chainId: number;
    r?: string;
    s?: string;
    v?: number;
}

[ricmoo]

I've spent the day trying to recall, and cannot. There was a weird case a long time ago, and I suspect it had to do with Ganache, but am not certain.

I will try making it non-optional in v5 and see if any issues crop up. I not, in v5 it won't be optional. :)

[naddison36]

That will save me using the bang(!) operator to appease the TS compiler. eg

const tx = await signer.sendTransaction(transaction)
const receipt = await provider.waitForTransaction(tx.hash!)

[ricmoo]

@naddison36 I have no idea what that post-fix operator does... TypeScript has some crazy things... Is that in the docs anywhere? Is it because you use the strict null checking?

[naddison36]

It was documented in the TypeScript 2.0 release notes https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#non-null-assertion-operator

[ricmoo]

Closing this now, as v5 has been updated to reflect this change.

Thanks! :)