Event Listening Bug when filter as no address [ethers-v5]

[pldespaigne]

Hello @ricmoo !
I was experimenting on private networks and I found a bug on the v5 version of ethers.

When listening on events via filters without any address I got an unexpected error network does not support ENS. I try to reproduce on v4.0.45 but everything works as intended.

Error

After some investigation I found that the error was caused by the filter serialization.

1. This line convert the empty address field into a '*'
2. When polling, this line is meant to remove empty address field, but it's never executed since empty addresses are always '*' instead of ''.
3. This result in the resolveProperties function trying to resolve '*' as an ENS name.

You can see that in ethers v4.0.45 the line of step 1) convert empty addresses in '' instead of '*'.
That is why there is no error in v4.

Proposed fix

Simply replace the line at step 1) of v5 by the one of v4.

Anyway thanks a lot for your work and your time!

[ricmoo]

Ack! Good catch. I'll fix this right away. Also thanks for investigating. :)

[ricmoo]

The changes are made and the tests are running.

Once they complete I'll publish to NPM.

[ricmoo]

Published to 5.0.0-beta.175. Try it out and let me know if you have any problems. :)

[pldespaigne]

Thanks @ricmoo you are the real MVP !