Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect git tag commits #828

Closed
sz-piotr opened this issue May 11, 2020 · 4 comments
Closed

Incorrect git tag commits #828

sz-piotr opened this issue May 11, 2020 · 4 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@sz-piotr
Copy link

I noticed that the release tags point to commits on master instead of ethers-v5-beta.

If you look here https://github.com/ethers-io/ethers.js/releases all of the tags point to the same 427e168 commit.

@ricmoo
Copy link
Member

ricmoo commented May 11, 2020

Ack! You're right! :(

I'll fidget with the admin script tomorrow to figure out why and fix that.

@ricmoo
Copy link
Member

ricmoo commented May 11, 2020

Looks like I'm not actually passing it in.

Thanks. I'll add that for the next release. And figure out how easy it is to backfill the existing tags.

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels May 11, 2020
@ricmoo
Copy link
Member

ricmoo commented May 13, 2020

The publish script has been updated and works.

I'll get to the backfill script this week and correct all the old tags. Each tag will be updated to the latest version which has the given CHANGELOG entry present.

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 13, 2020
@ricmoo
Copy link
Member

ricmoo commented May 13, 2020

The backfill script seems to have worked and I backfilled all the way back to when the changelog started.

Let me know if you find any other problems.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants