Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CJS browser bundling #4033

Closed
wants to merge 3 commits into from
Closed

Fix CJS browser bundling #4033

wants to merge 3 commits into from

Conversation

0xshippor
Copy link

@0xshippor 0xshippor commented May 8, 2023

Added browser aliases to misc/basedirs/lib.commonjs/package.json to support using CJS build in browser environments.

I encountered several module not found errors when porting internal react library from ethers v5 to v6 used within next.js app.

@ricmoo
Copy link
Member

ricmoo commented May 8, 2023

Thanks! I’ll add these tomorrow. I’m close to the v6.4 release. :)

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 minor-bump Planned for the next minor version bump. labels Jun 2, 2023
ricmoo added a commit that referenced this pull request Jun 7, 2023
@ricmoo
Copy link
Member

ricmoo commented Jun 7, 2023

Merged in v6.5.0.

Thanks! :)

@ricmoo ricmoo closed this Jun 7, 2023
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 8, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants