Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for webpack #599

Closed
wants to merge 1 commit into from
Closed

fix for webpack #599

wants to merge 1 commit into from

Conversation

wighawag
Copy link

@wighawag wighawag commented Sep 5, 2019

fixes #567

@ricmoo
Copy link
Member

ricmoo commented Sep 6, 2019

Can you try out 5.0.0-beta.156 and see if that works better with Webpack? It generates an ESM module that should work better.

But it definitely needs some testing in other frameworks, such as Angular, Expo and React Native.

@ricmoo ricmoo added the discussion Questions, feedback and general information. label Sep 6, 2019
@wighawag
Copy link
Author

wighawag commented Sep 7, 2019

Just tried and it looks like it is working!

@ricmoo
Copy link
Member

ricmoo commented Sep 8, 2019

Awesome! Closing this now, but if you have any issues feel free to re-open.

Thanks! :)

@ricmoo ricmoo closed this Sep 8, 2019
@snyk-bot snyk-bot mentioned this pull request Jun 29, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 7, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 17, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Oct 21, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Nov 22, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 2, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2022
Open
This was referenced Apr 13, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 3, 2022
Open
This was referenced Sep 29, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@jackromo888 jackromo888 mentioned this pull request Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
discussion Questions, feedback and general information.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wighawag @ricmoo