-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gift wallet #372
feat: gift wallet #372
Conversation
@@ -33,7 +29,6 @@ const Dashboard = (props: Props): ReactElement => { | |||
<Container className={classes.content}> | |||
<ErrorBoundary> | |||
<> | |||
<AlertVersion /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this removal intentional? I am done to remove it but maybe it should only be disabled for bee-desktop
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for removing this for the internal testing. It would be good to improve this, because the current version is very annoying (it comes back after a reload or when you open the page from the menu) and it requires us to have exactly the same version of Bee bundled with the desktop as the version that the bee-js supports that is bundled with the dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK we can remove it in this PR, but we can definitely reintroduce it with better mechanism. bee-js
has a different method to check version as that is less strict. And we can also remember the dismissal of the warning with specific version and timestamp to show it when the version changes or when e.g. 7 days pass.
🐝 PR preview in SwarmPreview URL: https://bah5acgzaqxulgxrhkxq3do766qkqaenl26dtwbomgamnxh4qs4mmewyntj3q.bzz.link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works fine
No description provided.