Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gift wallet #372

Merged
merged 16 commits into from
Jun 2, 2022
Merged

feat: gift wallet #372

merged 16 commits into from
Jun 2, 2022

Conversation

Cafe137
Copy link
Collaborator

@Cafe137 Cafe137 commented May 26, 2022

No description provided.

@Cafe137 Cafe137 linked an issue May 30, 2022 that may be closed by this pull request
@Cafe137 Cafe137 marked this pull request as ready for review May 30, 2022 09:23
src/components/CashoutModal.tsx Show resolved Hide resolved
@@ -33,7 +29,6 @@ const Dashboard = (props: Props): ReactElement => {
<Container className={classes.content}>
<ErrorBoundary>
<>
<AlertVersion />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removal intentional? I am done to remove it but maybe it should only be disabled for bee-desktop?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked for removing this for the internal testing. It would be good to improve this, because the current version is very annoying (it comes back after a reload or when you open the page from the menu) and it requires us to have exactly the same version of Bee bundled with the desktop as the version that the bee-js supports that is bundled with the dashboard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK we can remove it in this PR, but we can definitely reintroduce it with better mechanism. bee-jshas a different method to check version as that is less strict. And we can also remember the dismissal of the warning with specific version and timestamp to show it when the version changes or when e.g. 7 days pass.

src/models/Token.ts Outdated Show resolved Hide resolved
src/pages/accounting/PeerBalances.tsx Show resolved Hide resolved
src/pages/files/Upload.tsx Outdated Show resolved Hide resolved
src/pages/files/Upload.tsx Outdated Show resolved Hide resolved
@bee-worker
Copy link
Collaborator

🐝 PR preview in Swarm

Preview URL: https://bah5acgzaqxulgxrhkxq3do766qkqaenl26dtwbomgamnxh4qs4mmewyntj3q.bzz.link
Swarm Hash: 85e8b35e2755e1b1bbfef4150011abd7873b05cc3018db9f909718c25b0d9a77
Commit Hash: 25c1158
Commit Message: build: remove unused dependency

Copy link
Contributor

@vojtechsimetka vojtechsimetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grace period when starting up
4 participants