storage incentives: batch service and backing store #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
reviewed
Dec 23, 2020
| } | ||
| svc := newTestBatchService(t, store) | ||
|
|
||
| if err := svc.TopUp(testID, testAmount); err != nil { |
There was a problem hiding this comment.
confusing to use amount here when it is value we update
|
|
||
| const ( | ||
| batchKeyPrefix = "batchKeyPrefix" | ||
| // valueKeyPrefix = "valueKeyPrefix" |
There was a problem hiding this comment.
we need this index by value and replace/reinsert for topup and depth change
| @@ -0,0 +1,34 @@ | |||
| package mock | |||
| // Batch represents a postage batch, a payment on the blockchain. | ||
| type Batch struct { | ||
| ID []byte // batch ID | ||
| Value *big.Int // overall balance of the batch |
| // EventUpdater interface definitions reflect the updates triggered by events | ||
| // emitted by the postage contract on the blockchain | ||
| type EventUpdater interface { | ||
| Create(id []byte, owner []byte, amount *big.Int, depth uint8) error |
|
closed in favor of #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1046 #922 and parts of #934