wire up postage stamp syncing #1114

ralph-pichler · 2021-01-15T11:47:39Z

add flags for contract addresses
this reuses swap endpoint which means swap endpoint is required even if swap is off
adds updateBlockNumber to event updater
node.go wiring

acud

LGTM

pkg/postage/listener/listener_test.go

acud · 2021-01-16T13:08:32Z

pkg/postage/listener/listener.go

@@ -198,6 +208,11 @@ func (l *listener) sync(from uint64, updater postage.EventUpdater) error {
 			}
 		}

+		err = updater.UpdateBlockNumber(to)


I think that moving the block height to the actual individual event signatures on EventUpdater and using the Log.BlockNumber (and thus updating the chain state on every write in batch service) would be more consistent. Then we can avoid this method altogether. WDYT?

the advantage of this approach is that the block number is only updated after the entire block has been processed. whereas if its on individual events it's already updated after the first event. if the bee node stops/crashes mid-processing a block it will reprocess some events but that should be fine as all of them should be idempotent (at least better than skipping anything).

paxthemax

LGTM

postage: new pkg for postage stamps, uploader stamping (#890) * postage: new pkg for postage stamps, uploader stamping * postage: amount->value, blockNumber big.Int-> uint64, stamp only has batch ID, not Batch * postage: fix godoc and copyright * postage, swarm: - swarm.Stamp as an interface - add postage/testing for mock Stamps - fix Stamp MarshalBinary to allow nil batch id and signature - add StampSize const * postage: heed review feedback Co-authored-by: acud <[email protected]> Storage incentives: add stamper putter to api Postage BatchStore and BatchService (#1070) Co-authored-by: zelig <[email protected]> add normalisedBalance to updater interface (#1108) make value the normalised balance (#1111) postage: add event listener (#1099) Wire up postage stamp syncing (#1114) localstore, shed: persist stamps (#1116) add --postage to beeinfra.sh setup pullsync, pushsync: add postage stamps (#1117) postage: add create endpoint (#1142) retrieve erc20 address from postage contract (#1169) postage: check balance before attempting stamp creation (#1177) postage: fix bucket depth (#1178) api: use hex encoding in postage api (#1179) increase page size (#1182) postage: handle bucket depth error in api (#1183) localstore: attach stamp to outgoing chunk (#1192) update postage stamp contract addresses for new token (#1208) batchstore: reserve (#1262) * postage/batchstore: reserve logic Co-authored-by: acud <[email protected]> stamp support in storage and protocols (#1321) api: endpoints for stamp issuers (#1535) retrieval: add stamps (#1552) localstore reserve logic (#1322) Co-authored-by: acud <[email protected]>

bee-runner bot added the pull-request label Jan 15, 2021

ralph-pichler self-assigned this Jan 15, 2021

ralph-pichler force-pushed the postage_wiring branch from 2d7910d to 54c0a11 Compare January 15, 2021 13:54

Base automatically changed from event-listener to storage-incentives January 15, 2021 14:14

ralph-pichler force-pushed the postage_wiring branch from 54c0a11 to e169fda Compare January 15, 2021 15:40

acud force-pushed the storage-incentives branch from 4d18bcf to deae8f4 Compare January 15, 2021 18:07

wire up postage stamp syncing

b9054b5

ralph-pichler force-pushed the postage_wiring branch from e169fda to b9054b5 Compare January 16, 2021 12:35

ralph-pichler marked this pull request as ready for review January 16, 2021 12:47

acud approved these changes Jan 16, 2021

View reviewed changes

ralph-pichler added 4 commits January 16, 2021 14:27

add postage stamp contract address discovery

74a3dfe

remove test code

3998f3d

fix standalone

c4343cb

reuse logger in tests

fb7d20a

zelig approved these changes Jan 17, 2021

View reviewed changes

zelig added the ready for review The PR is ready to be reviewed label Jan 17, 2021

paxthemax approved these changes Jan 17, 2021

View reviewed changes

paxthemax merged commit f6ecf76 into storage-incentives Jan 17, 2021

paxthemax deleted the postage_wiring branch January 17, 2021 20:35

acud pushed a commit that referenced this pull request Jan 27, 2021

Wire up postage stamp syncing (#1114)

dc3e3bd

acud pushed a commit that referenced this pull request Feb 1, 2021

Wire up postage stamp syncing (#1114)

90ed030

acud pushed a commit that referenced this pull request Feb 3, 2021

Wire up postage stamp syncing (#1114)

43728bd

acud pushed a commit that referenced this pull request Feb 9, 2021

Wire up postage stamp syncing (#1114)

eaaf6d4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wire up postage stamp syncing #1114

wire up postage stamp syncing #1114

ralph-pichler commented Jan 15, 2021 •

edited

Loading

acud left a comment

acud Jan 16, 2021

ralph-pichler Jan 16, 2021

paxthemax left a comment

wire up postage stamp syncing #1114

wire up postage stamp syncing #1114

Conversation

ralph-pichler commented Jan 15, 2021 • edited Loading

acud left a comment

Choose a reason for hiding this comment

acud Jan 16, 2021

Choose a reason for hiding this comment

ralph-pichler Jan 16, 2021

Choose a reason for hiding this comment

paxthemax left a comment

Choose a reason for hiding this comment

ralph-pichler commented Jan 15, 2021 •

edited

Loading