Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage incentives reservestate api #1586

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Storage incentives reservestate api #1586

merged 1 commit into from
Apr 21, 2021

Conversation

istae
Copy link
Member

@istae istae commented Apr 20, 2021

No description provided.

@istae istae added the ready for review The PR is ready to be reviewed label Apr 20, 2021
@istae istae requested a review from acud April 20, 2021 19:14
@istae istae changed the base branch from master to storage-incentives-rebased April 20, 2021 19:14
@istae
Copy link
Member Author

istae commented Apr 20, 2021

reservestate

zelig
zelig reviewed Apr 21, 2021
View reviewed changes
Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding a test?

acud
acud approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for a small test in debugapi

@istae istae force-pushed the storage-incentives-reservestate-api branch from 4f431ea to 6817486 Compare April 21, 2021 10:25
@istae istae requested a review from zelig April 21, 2021 10:26
acud
acud reviewed Apr 21, 2021
View reviewed changes
pkg/postage/reservestate.go Outdated Show resolved Hide resolved
acud
acud suggested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments relating to passing of big.Ints

@istae istae force-pushed the storage-incentives-reservestate-api branch from 6817486 to c99e18d Compare April 21, 2021 11:29
@istae istae requested a review from acud April 21, 2021 11:29
acud
acud reviewed Apr 21, 2021
View reviewed changes
pkg/postage/reservestate.go
@@ -0,0 +1,10 @@
package postage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright missing here. otherwise LGTM

acud
acud reviewed Apr 21, 2021
View reviewed changes
pkg/debugapi/postage_test.go Outdated
@@ -0,0 +1,31 @@
// Copyright 2020 The Swarm Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021

acud
acud reviewed Apr 21, 2021
View reviewed changes
pkg/debugapi/postage.go Outdated
@@ -0,0 +1,15 @@
// Copyright 2020 The Swarm Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21

@istae istae force-pushed the storage-incentives-reservestate-api branch from c99e18d to e066f48 Compare April 21, 2021 18:24
@istae istae merged commit f6d94b2 into storage-incentives-rebased Apr 21, 2021
@istae istae deleted the storage-incentives-reservestate-api branch April 21, 2021 18:27
acud pushed a commit that referenced this pull request Apr 26, 2021
@istae @acud
reserve state debug api (#1586)
470ea71
acud pushed a commit that referenced this pull request Apr 27, 2021
@istae @acud
reserve state debug api (#1586)
05bce02
acud pushed a commit that referenced this pull request Apr 27, 2021
@istae @acud
reserve state debug api (#1586)
cf0a1f1
@AuHau
Copy link
Contributor

AuHau commented May 3, 2021

Btw. @esadakar the new GET /reservestate endpoint is not documented in OpenAPI ;-)

@AuHau AuHau mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acud acud acud approved these changes

@zelig zelig Awaiting requested review from zelig

Assignees
No one assigned
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@istae @AuHau @zelig @acud