libp2p: improve cleanup on shutdown #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatollupacescu
approved these changes
Apr 29, 2021
mrekucci
reviewed
Apr 29, 2021
pkg/p2p/libp2p/connections_test.go
Outdated
| _, err = s1.Connect(context.Background(), addr2) | ||
| if err == nil { | ||
| t.Fatal("expected error during connection, got nil") | ||
| } | ||
| t.Logf("s1 connect threw error: %v", err) |
There was a problem hiding this comment.
r: In the tests, this message looks like a false positive:
=== RUN TestBlocklisting
connections_test.go:347: s1 connect threw error: connect full close stream reset
--- PASS: TestBlocklisting (2.41s)
PASSIt is really needed here? Maybe we should rather assert this error or rewrite the message in a clearer way.
There was a problem hiding this comment.
woops. leftovers :) removing. thanks!
mrekucci
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds nat manager cleanup to libp2p close