Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: send version info to stdout #1660

Merged
merged 3 commits into from
May 5, 2021
Merged

cmd: send version info to stdout #1660

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
681b483
cmd: send version info to stdout
acud May 5, 2021
0aff6ab
pr review comments
acud May 5, 2021
3132482
Merge branch 'master' into fix-version-stout
acud May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/bee/cmd/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@ import (
)

func (c *command) initVersionCmd() {
c.root.AddCommand(&cobra.Command{
v := &cobra.Command{
Use: "version",
Short: "Print version number",
Run: func(cmd *cobra.Command, args []string) {
cmd.Println(bee.Version)
},
})
}
v.SetOut(c.root.OutOrStdout())
c.root.AddCommand(v)
}
4 changes: 2 additions & 2 deletions pkg/p2p/libp2p/connections_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,8 @@ func TestBlocklisting(t *testing.T) {
t.Fatal("expected error during connection, got nil")
}

expectPeers(t, s1)
expectPeersEventually(t, s2)
expectPeersEventually(t, s1)
expectPeers(t, s2)
}

func TestTopologyNotifier(t *testing.T) {
Expand Down