localstore: preliminary changes related to postage stamps/batches #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
force-pushed
the
postage-localstore
branch
2 times, most recently
from
5f4fc3b
to
c5e2271
Compare
|
Please attach this one to an issue. If no issue exists -- make an issue. Thanks |
acud
force-pushed
the
storage-incentives
branch
2 times, most recently
from
134fa9a
to
cbd4d4a
Compare
postage: new pkg for postage stamps, uploader stamping (#890) * postage: new pkg for postage stamps, uploader stamping * postage: amount->value, blockNumber big.Int-> uint64, stamp only has batch ID, not Batch * postage: fix godoc and copyright * postage, swarm: - swarm.Stamp as an interface - add postage/testing for mock Stamps - fix Stamp MarshalBinary to allow nil batch id and signature - add StampSize const * postage: heed review feedback Co-authored-by: acud <[email protected]>
zelig
force-pushed
the
postage-localstore
branch
from
c5e2271
to
5251e14
Compare
zelig
force-pushed
the
storage-incentives
branch
from
cbd4d4a
to
97b2a15
Compare
zelig
force-pushed
the
postage-localstore
branch
4 times, most recently
from
98f924a
to
29c4a73
Compare
zelig
force-pushed
the
postage-localstore
branch
from
29c4a73
to
8688cc1
Compare
acud
force-pushed
the
storage-incentives
branch
from
4d18bcf
to
deae8f4
Compare
|
@acud , this PR is in the QA and Documentation workspaces in the Done column. For me, it can be closed, but I see now that this is still active. Could you please let me know about the status of this issue? |
acud
force-pushed
the
storage-incentives
branch
2 times, most recently
from
039d4ab
to
a1094ff
Compare
acud
force-pushed
the
storage-incentives
branch
from
e8dd480
to
9dfe3c2
Compare
acud
force-pushed
the
storage-incentives
branch
from
20da387
to
322bdbf
Compare
|
obsoleted by #1321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this incomplete PR implements preliminary changes to localstore related to postage stamps as captured in architecture proposals #895 and #898
missing
postageBatchChunksIndexpotential technical debt:
swarm.NewChunk