Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

cmd/swarm/swarm-smoke: sliding window test #1136

Closed
wants to merge 10 commits into from
Closed

cmd/swarm/swarm-smoke: sliding window test #1136

wants to merge 10 commits into from

Conversation

acud
Copy link
Member

@acud acud commented Jan 18, 2019 •
edited by nonsense
Loading

fixes #1095

example kubernetes deployment manifest:

smoke:
  image:
    repository: ethdevops/swarm
    tag: <tagg>
  schedule: "*/10 * * * *"
  config:
    swarmReplicas: 10
    operation: "sliding_window"
    extraFlags:
      - --sync-delay=60
      - --store=1500
      - --timeout=600
      - --single

@acud acud self-assigned this Jan 18, 2019
@acud acud force-pushed the sliding-window-test branch 3 times, most recently from 701540b to 5a27399 Compare January 22, 2019 15:07
@nonsense nonsense self-requested a review January 22, 2019 15:11
nonsense
nonsense suggested changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I like the simplification of the wrap function, I am not sure this is the test when downloading all historical hashes that were uploaded.

@acud acud force-pushed the sliding-window-test branch 4 times, most recently from 29cd89a to b7ec0a6 Compare January 25, 2019 07:11
@acud acud requested review from janos and zelig as code owners January 25, 2019 07:11
janos
janos reviewed Jan 25, 2019
View reviewed changes
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a complete review. I still did not go through all changes.

cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/util.go Show resolved Hide resolved
cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
janos
janos reviewed Jan 25, 2019
View reviewed changes
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments to the first review.

cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/sliding_window.go Outdated Show resolved Hide resolved
cmd/swarm/swarm-smoke/util.go Show resolved Hide resolved
janos
janos approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justelad Thank you for addressing my comments and suggestions. LGTM.

@acud acud mentioned this pull request Jan 30, 2019
Merged
@acud
Copy link
Member Author

acud commented Jan 30, 2019

submitted upstream ethereum/go-ethereum#18967

@acud acud closed this Jan 30, 2019
@frncmx frncmx deleted the sliding-window-test branch February 5, 2019 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nonsense nonsense nonsense requested changes

@janos janos janos approved these changes

@gluk256 gluk256 gluk256 approved these changes

@zelig zelig Awaiting requested review from zelig

Assignees

@acud acud

Labels
ready for another review test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create test to validate the distribution of chunks among nodes
4 participants
@acud @nonsense @janos @gluk256