This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Fix a data race on startTime #1155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
approved these changes
Jan 23, 2019
frncmx
approved these changes
Jan 23, 2019
acud
approved these changes
Jan 23, 2019
|
Submitted upstream ethereum/go-ethereum#18511. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses data race described in #1154.
Global variable startTime was used concurrently. But given the nature of its usage it just have to be specific to a Swarm instance, and it does not require a lock:
There is another issue with unterminated updateGauges goroutine created by periodicallyUpdateGauges, but this is a subject to another issue (#1156).