Update content addressed github uri scheme #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
http-uris
branch
from
86d8a40
to
4126a33
Compare
pipermerriam
requested changes
Dec 4, 2018
ethpm/backends/http.py
Outdated
| "Expected contents returned from Github to be base64 encoded, " | ||
| f"instead received {contents['encoding']}." | ||
| ) | ||
| return base64.b64decode(contents["content"]) |
There was a problem hiding this comment.
Maybe I missed it but I expected to see somewhere that we verify that the contents match the hash. If that isn't present I think it needs to be added.
There was a problem hiding this comment.
Yup, I chose to remove that for some reason that escapes me now, I'll set about re-implementing that.
ethpm/utils/uri.py
Outdated
| if not all((path, scheme, authority)): | ||
| return False | ||
|
|
||
| if [term for term in expected_path_terms if term not in path]: |
There was a problem hiding this comment.
Generally the pattern for this is to use any
if any(term for term in expected_path_terms if not term in path):
...The nice part about this is that it is lazy meaning it will exit on the first one that is truthy.
njgheorghita
force-pushed
the
http-uris
branch
2 times, most recently
from
b287c43
to
7c911ed
Compare
njgheorghita
force-pushed
the
http-uris
branch
10 times, most recently
from
4ea7c34
to
7655cb4
Compare
njgheorghita
force-pushed
the
http-uris
branch
from
7655cb4
to
4a90b18
Compare
|
@pipermerriam ping - added a validation util to verify that the hash of the contents retrieved from a github blob uri match the hash in the uri |
pipermerriam
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Decision was made to sunset the fragment based hash verification for github uris and use their native blob system instead - Also mirrors what is suggested in the ERC 1319, so this will go towards having a cleaner standard amongst libraries.
How was it fixed?
Updated the utils and
GithubOverHTTPSbackend to use the blob scheme.Cute Animal Picture
fixes #125