Change the shard size in the deployL2-it.js to 1GB to support test multi-shards in the integration test. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why 1 GB instead of 4 GB? How much time it will cost to upload 1 GB data to the layer 2? |
qzhodl
reviewed
Sep 9, 2024
qzhodl
approved these changes
Sep 9, 2024
iteyelmp
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the shard size in the deployL2-it.js to 1GB to support test multi-shards in the integration test.
As we want to upload more than 1 shard of data and assume that the second shard already has about 30% of the data:
If the shard size is 1G (8192 blobs), then we can upload 10,800 blobs (8192 blobs in shard 0 and 2608 blobs in shard 1 to make it easy to calculate) using writeBlobs with batch size 6. Then, we need to upload 1800 times, which would take at least 3600s = 1h.
If the shard size is 4G (32,768 blobs), then we can upload 10,800 * 4 = 43,200 blobs (same data coverage in shard 1) using writeBlobs with a batch size of 6, then we need to upload 7,200 times which would take at least 14,400s = 4h.
Considering that not every transaction can be included in the block, it may take more than 12 hours, so change the value to 1G.