Fixing condition for rendering overlay (#4515)

ethyca · Jan 2, 2024 · 2b520e9 · 2b520e9
1 parent b64133f
commit 2b520e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -28,6 +28,7 @@ The types of changes are:
 - Fixed incorrect Compass button behavior in system form [#4508](https://github.com/ethyca/fides/pull/4508)
 - Omit certain fields from system payload when empty  [#4508](https://github.com/ethyca/fides/pull/4525)
 - Fixed issues with Compass vendor selector behavior [#4521](https://github.com/ethyca/fides/pull/4521)
+- Fixed an issue where the background overlay remained visible after saving consent preferences [#4515](https://github.com/ethyca/fides/pull/4515)
 
 ### Changed
 - Upgrade to use Fideslang `3.0.0` and remove associated concepts [#4502](https://github.com/ethyca/fides/pull/4502)

diff --git a/clients/fides-js/src/components/Overlay.tsx b/clients/fides-js/src/components/Overlay.tsx
@@ -150,7 +150,7 @@ const Overlay: FunctionComponent<Props> = ({
 
   return (
     <div>
-      {bannerIsOpen && window.Fides.options.preventDismissal && (
+      {showBanner && bannerIsOpen && window.Fides.options.preventDismissal && (
         <div className="fides-modal-overlay" />
       )}
       {showBanner