Skip to content

Commit

Permalink
cleanup based on code review
Browse files Browse the repository at this point in the history
  • Loading branch information
adamsachs committed Jun 29, 2023
1 parent ee9a085 commit 53b3611
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 166 deletions.
2 changes: 1 addition & 1 deletion docs/fides/docs/development/development_tips.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ If you're looking for a general getting started guide, please see the [Overview]

### API URLs

We define API URLs for specific API versions as constants within `fides.api.api.v1.urn_registry` (where `v1` can be substituted for that particular API version), then import those URLs into their specific API views. Since we are on the first version, there is no clear precedent set for overriding URLs between versions yet. The most likely change is that we'll override the `APIRouter` class instantiation with a different base path (ie. `/api/v2` instead of `/api/v1`). For example:
We define API URLs for specific API versions as constants within `fides.common.api.v1.urn_registry` (where `v1` can be substituted for that particular API version), then import those URLs into their specific API views. Since we are on the first version, there is no clear precedent set for overriding URLs between versions yet. The most likely change is that we'll override the `APIRouter` class instantiation with a different base path (ie. `/api/v2` instead of `/api/v1`). For example:

```sh
PRIVACY_REQUEST = "/privacy-request"
Expand Down
164 changes: 0 additions & 164 deletions src/fides/api/util/utils.py

This file was deleted.

2 changes: 1 addition & 1 deletion tests/ctl/core/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from fides.api.models.sql_models import Dataset, PrivacyDeclaration, System
from fides.api.oauth.roles import OWNER, VIEWER
from fides.api.schemas.system import PrivacyDeclarationResponse
from fides.api.util.utils import API_PREFIX, CLI_SCOPE_PREFIX_MAPPING
from fides.api.util.endpoint_utils import API_PREFIX, CLI_SCOPE_PREFIX_MAPPING
from fides.common.api.scope_registry import (
CREATE,
DELETE,
Expand Down

0 comments on commit 53b3611

Please sign in to comment.