remove all references to gvl_translations

ethyca · Jul 17, 2024 · f7fa793 · f7fa793
1 parent 3cb8368
commit f7fa793
Show file tree

Hide file tree

Showing 12 changed files with 8 additions and 1,082 deletions.
diff --git a/clients/fides-js/__tests__/__fixtures__/mock_experience.json b/clients/fides-js/__tests__/__fixtures__/mock_experience.json
@@ -133,6 +133,5 @@
       ]
     }
   ],
-  "gvl": {},
-  "gvl_translations": {}
+  "gvl": {}
 }
diff --git a/clients/fides-js/__tests__/lib/i18n/i18n-utils.test.ts b/clients/fides-js/__tests__/lib/i18n/i18n-utils.test.ts
@@ -370,7 +370,7 @@ describe("i18n-utils", () => {
         const [, loadedMessagesEn] = mockI18n.load.mock.calls[0];
         const [, loadedMessagesEs] = mockI18n.load.mock.calls[1];
 
-        // Confirm that the English gvl_translations are loaded
+        // Confirm that the English GVL translations are loaded
         const expectedMessagesEn: Record<string, RegExp> = {
           // Example purposes
           "exp.tcf.purposes.1.name": /^Store and\/or access/,
@@ -401,7 +401,7 @@ describe("i18n-utils", () => {
           expect(loadedMessagesEn[id]).toMatch(regex);
         });
 
-        // Confirm that the Spanish gvl_translations are loaded
+        // Confirm that the Spanish GVL translations are loaded
         const expectedMessagesEs: Record<string, RegExp> = {
           // Example purposes
           "exp.tcf.purposes.1.name": /^Almacenar la información/,

diff --git a/clients/fides-js/src/lib/consent-types.ts b/clients/fides-js/src/lib/consent-types.ts
@@ -2,7 +2,6 @@ import type { Fides, FidesOptions } from "../docs";
 import type { GPPFieldMapping, GPPSettings } from "./gpp/types";
 import type {
   GVLJson,
-  GVLTranslations,
   TCFFeatureRecord,
   TCFFeatureSave,
   TCFPurposeConsentRecord,
@@ -414,7 +413,6 @@ export type PrivacyExperience = {
    */
   experience_config?: ExperienceConfig; // NOTE: uses our client-side ExperienceConfig type
   gvl?: GVLJson; // NOTE: uses our client-side GVLJson type
-  gvl_translations?: GVLTranslations;
   meta?: ExperienceMeta;
   available_locales?: string[];
 };

diff --git a/clients/fides-js/src/lib/i18n/i18n-utils.ts b/clients/fides-js/src/lib/i18n/i18n-utils.ts
@@ -146,7 +146,7 @@ export function extractDefaultLocaleFromExperience(
 }
 
 /**
- * Helper function to extract all the translated messages from the "gvl_translations"
+ * Helper function to extract all the translated messages from the GVL translations
  * API response. Returns an object that maps locales -> messages, e.g.
  * {
  *   "en": {

diff --git a/clients/fides-js/src/services/api.ts b/clients/fides-js/src/services/api.ts
@@ -89,7 +89,6 @@ export const fetchExperience = async (
     // that have no relevant experiences
     const experience: PrivacyExperience = (body.items && body.items[0]) ?? {};
     debugLog(debug, "Recieved experience response from Fides API", experience);
-    delete experience.gvl_translations;
     return experience;
   } catch (e) {
     debugLog(

diff --git a/clients/privacy-center/cypress/fixtures/consent/experience_banner_modal.json b/clients/privacy-center/cypress/fixtures/consent/experience_banner_modal.json
@@ -179,8 +179,7 @@
           ]
         }
       ],
-      "gvl": {},
-      "gvl_translations": {}
+      "gvl": {}
     }
   ],
   "total": 1,

diff --git a/clients/privacy-center/cypress/fixtures/consent/experience_banner_modal_notice_only.json b/clients/privacy-center/cypress/fixtures/consent/experience_banner_modal_notice_only.json
@@ -107,8 +107,7 @@
           ]
         }
       ],
-      "gvl": {},
-      "gvl_translations": {}
+      "gvl": {}
     }
   ],
   "total": 1,

diff --git a/clients/privacy-center/cypress/fixtures/consent/experience_gpp.json b/clients/privacy-center/cypress/fixtures/consent/experience_gpp.json
@@ -130,7 +130,6 @@
         }
       ],
       "gvl": {},
-      "gvl_translations": {},
       "meta": {
         "version_hash": null,
         "accept_all_fides_string": null,

diff --git a/clients/privacy-center/cypress/fixtures/consent/experience_privacy_center.json b/clients/privacy-center/cypress/fixtures/consent/experience_privacy_center.json
@@ -179,8 +179,7 @@
           ]
         }
       ],
-      "gvl": {},
-      "gvl_translations": {}
+      "gvl": {}
     }
   ],
   "total": 1,

diff --git a/clients/privacy-center/cypress/fixtures/consent/experience_tcf.json b/clients/privacy-center/cypress/fixtures/consent/experience_tcf.json
diff --git a/clients/privacy-center/cypress/fixtures/consent/fidesjs_options_banner_modal.json b/clients/privacy-center/cypress/fixtures/consent/fidesjs_options_banner_modal.json
@@ -191,8 +191,7 @@
         ]
       }
     ],
-    "gvl": {},
-    "gvl_translations": {}
+    "gvl": {}
   },
   "geolocation": {
     "country": "US",

diff --git a/src/fides/api/models/privacy_experience.py b/src/fides/api/models/privacy_experience.py
@@ -535,7 +535,6 @@ def show_banner(self) -> bool:
     tcf_system_consents: List = []
     tcf_system_legitimate_interests: List = []
     gvl: Optional[Dict] = {}
-    gvl_translations: Optional[Dict] = {}
     # TCF Developer-Friendly Meta added at runtime as the result of build_tc_data_for_mobile
     meta: Dict = {}