Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous CODEOWNERS #1445

Closed
PSalant726 opened this issue Oct 14, 2022 · 0 comments · Fixed by #1446
Closed

Remove superfluous CODEOWNERS #1445

PSalant726 opened this issue Oct 14, 2022 · 0 comments · Fixed by #1446
Assignees
@PSalant726
Labels
bug Something isn't working dev experience Targets the developer experience

Comments

@PSalant726
Copy link
Contributor

PSalant726 commented Oct 14, 2022 •
edited by mfbrown
Loading

Bug Description

The CODEOWNERS file is too generalized, and creates unnecessary notifications for Ethyca employees.

Expected behavior

Ethyca employees should automatically be requested for PR reviews only when those PRs modify files relevant to them.

Additional context

Until there is more clarity with respect to the division of labor (if any) in this repo, all CODEOWNERS other than the docs-authors team should be removed.
@PSalant726 PSalant726 added bug Something isn't working dev experience Targets the developer experience labels Oct 14, 2022
@PSalant726 PSalant726 self-assigned this Oct 14, 2022
@PSalant726 PSalant726 mentioned this issue Oct 14, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSalant726 PSalant726

Labels
bug Something isn't working dev experience Targets the developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove superfluous CODEOWNERS ethyca/fides
1 participant
@PSalant726