Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous CODEOWNERS #1446

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Remove superfluous CODEOWNERS #1446

merged 3 commits into from
Oct 17, 2022

Conversation

PSalant726
Copy link
Contributor

@PSalant726 PSalant726 commented Oct 14, 2022

Closes #1445

Code Changes

  • Remove automations and experience teams from CODEOWNERS
  • Specify that the docs-authors team owns the docs/ directory only at the repo root

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@PSalant726 PSalant726 added bug Something isn't working dev experience Targets the developer experience Unified Fides hacktoberfest-accepted labels Oct 14, 2022
@PSalant726 PSalant726 self-assigned this Oct 14, 2022
@PSalant726 PSalant726 marked this pull request as ready for review October 14, 2022 16:35
@PSalant726 PSalant726 requested review from a team October 14, 2022 16:35
@ThomasLaPiana
Copy link
Contributor

@PSalant726 this looks good to me, but I think we need input from @seanpreston and @Kelsey-Ethyca , as well as a retro discussion to socialize this change since some people might still assume their PRs are getting auto-assigned

@seanpreston
Copy link
Contributor

Thanks @PSalant726

some people might still assume their PRs are getting auto-assigned

I don't think there's any consistent expectation here on the team, so some messaging would go a long way. I don't mind if that's retro-based or an update to #engineering on Slack for instance.

@ThomasLaPiana
Copy link
Contributor

Thanks @PSalant726

some people might still assume their PRs are getting auto-assigned

I don't think there's any consistent expectation here on the team, so some messaging would go a long way. I don't mind if that's retro-based or an update to #engineering on Slack for instance.

as it affects the whole engineering org, I think merging this and then writing an update in #engineering would be the play so we let people know they need to take charge of finding people to review their PRs

Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but let's merge when we confirm a communication strategy

@PSalant726
Copy link
Contributor Author

@ThomasLaPiana Spoke with @seanpreston and I'll slack the #engineering channel about this. These notifications are extremely intrusive and need to be disabled ASAP.

@PSalant726 PSalant726 merged commit 98847e2 into main Oct 17, 2022
@PSalant726 PSalant726 deleted the remove-extra-codeowners branch October 17, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev experience Targets the developer experience hacktoberfest-accepted Unified Fides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove superfluous CODEOWNERS
3 participants