-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove superfluous CODEOWNERS
#1446
Conversation
8cad619
to
7def1c6
Compare
@PSalant726 this looks good to me, but I think we need input from @seanpreston and @Kelsey-Ethyca , as well as a retro discussion to socialize this change since some people might still assume their PRs are getting auto-assigned |
Thanks @PSalant726 —
I don't think there's any consistent expectation here on the team, so some messaging would go a long way. I don't mind if that's retro-based or an update to #engineering on Slack for instance. |
as it affects the whole engineering org, I think merging this and then writing an update in #engineering would be the play so we let people know they need to take charge of finding people to review their PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but let's merge when we confirm a communication strategy
@ThomasLaPiana Spoke with @seanpreston and I'll slack the #engineering channel about this. These notifications are extremely intrusive and need to be disabled ASAP. |
Closes #1445
Code Changes
CODEOWNERS
docs/
directory only at the repo rootPre-Merge Checklist
CHANGELOG.md