Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled connectors cause erasure requests to error #2048

Closed
adamsachs opened this issue Dec 15, 2022 · 0 comments · Fixed by #2045
Closed

Disabled connectors cause erasure requests to error #2048

adamsachs opened this issue Dec 15, 2022 · 0 comments · Fixed by #2045
Assignees
Labels
bug Something isn't working

Comments

@adamsachs
Copy link
Contributor

Bug Description

When running an erasure request that traverses through a dataset associated with a disabled connector, that erasure request will appear in an errored state (even if it does successfully process erasures for non-disabled connectors).

The underlying error is a KeyError that's being thrown because there is no cache entry for access results for the disabled connector's dataset, and the erasure execution is expecting there to be a cache entry, even if an empty one.

Steps to Reproduce

  1. get an environment up with nox -s test_env
  2. disable one or both of the Postgresql and MongoDB connectors that are configured by default
  3. try running a sample erasure request. you can use a fake email identity, e.g.:
curl --location --request POST 'http://0.0.0.0:8080/api/v1/privacy-request' \
--header 'Content-Type: application/json' \
--data-raw '[
    {
        "identity": {"email": "[email protected]"},
        "policy_key": "default_erasure_policy"
    }
]'
  1. navigate and log in to the admin UI and approve the request that's been queued. you should see it quickly move to an ERROR state

Expected behavior

  • The privacy request should not error, but should go to a COMPLETE state, even if it's not erasing any data

Environment

test_env, or any other fides environment really

Additional context

In some testing with @Roger-Ethyca and @RobertKeyser, we'd noticed some strange behavior where it seemed like a disabled saas connector was throwing an error depending on what the MASKING_STRICT config property was set to. i've been unable to reproduce that specific symptom locally and i can't see any way in which the MASKING_STRICT property will actually matter in cases where a connector is disabled.

In doing that investigation, though, I noticed the issue here. It's possible that this is actually what we'd been seeing in our testing and we just weren't keeping track of the symptoms closely enough, but i'm not sure about that.

@adamsachs adamsachs added the bug Something isn't working label Dec 15, 2022
@adamsachs adamsachs self-assigned this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant