avoid error if access results key is not found for erasures #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsachs
force-pushed
the
explore-disabled-connectors-bugs
branch
from
a2aaa72
to
f13b259
Compare
in cases where connector is disabled, there won't be an entry in the acces results for that connector's key. instead of throwing a key error, we instead just pass in an empty list to the erasure execution, which will not actually execute anyway.
adamsachs
force-pushed
the
explore-disabled-connectors-bugs
branch
from
f13b259
to
3a6dd3d
Compare
pattisdr
approved these changes
Dec 15, 2022
|
I agree @adamsachs this is likely unrelated and resolved by re-running! |
|
CI is being stubborn with the integration tests. the tests are passing locally and there's no connection between the failure reported here and the changed code. Merging rather than fighting this more, i think we're good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2048
Code Changes
[]if, in the beginning of erasure request execution, no access result cache entry is found for the given collectionSteps to Confirm
COMPLETEEvent Detailsfor the step associated with the disabled connector show all of its events withskippedstatusPre-Merge Checklist
CHANGELOG.mdDescription Of Changes
Passing in the empty list is effectively a no-op here, just a way to prevent an error. This is because the list doesn't actually get used, as the erasure request execution will not proceed because the connector is disabled.