Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor worker healthchecks #3912

Closed
daveqnet opened this issue Aug 10, 2023 · 1 comment · Fixed by #3947
Closed

Refactor worker healthchecks #3912

daveqnet opened this issue Aug 10, 2023 · 1 comment · Fixed by #3947
Assignees

Comments

@daveqnet
Copy link
Contributor

Is your feature request related to a specific problem?

Describe the solution you'd like

As discussed with @ThomasLaPiana:

  • Move the worker health check to a separate endpoint. This keeps health lean and quick, while still giving us the ability to check in on the workers if we need to
  • Dig in and find a better, more performant replacement for the old worker check

Describe alternatives you've considered, if any

Do nothing, but this leaves fides open to reliability issues.

@ThomasLaPiana
Copy link
Contributor

@daveqnet FYI I've got a PR up that should fix this. It is still relatively high latency but it now has its own endpoint so we can set that accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants