-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add database and worker health endpoints #3947
Add database and worker health endpoints #3947
Conversation
Passing run #3662 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
- Coverage 87.40% 87.35% -0.05%
==========================================
Files 318 318
Lines 19509 19533 +24
Branches 2504 2507 +3
==========================================
+ Hits 17051 17063 +12
- Misses 2024 2034 +10
- Partials 434 436 +2
☔ View full report in Codecov by Sentry. |
…://github.com/ethyca/fides into ThomasLaPiana-add-additional-health-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! i like the approach of decoupling the potentially more complex health checks from the straightforward heartbeat: gives us that level of detail if needed, while keeping the heartbeat as lightweight as possible.
also, thanks for switching over to the shared API db session that respects the configured connection pool! 👍
Closes #3912
Description Of Changes
After removing the more robust/verbose healthchecks, we've found that they were actually useful and should be reinstated for debugging use as discrete endpoints that don't affect the general latency of
/health
Code Changes
health/database
and restore functionality to check migration statushealth/workers
and restore the previous functionalityhealth
endpointSteps to Confirm
nox -s dev
and verify the 3 endpoints in your browser/HTTP requester (/health
,/health/database
,/health/workers
)Pre-Merge Checklist
CHANGELOG.md