Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to take a custom composite fides_tc_string and parse out TC and AC strings #4263

Closed
allisonking opened this issue Oct 12, 2023 · 2 comments · Fixed by #4308
Closed
Assignees

Comments

@allisonking
Copy link
Contributor

allisonking commented Oct 12, 2023

Is your feature request related to a specific problem?

#4262 adds the ability to take in a custom fides_tc_string in order to overwrite initial settings. This string will actually be a composite string, comma separated into {TC_STRING},{AC_STRING} and so we need to be able to handle that.

Describe the solution you'd like

In theory we already have the logic to initialize from TC_STRING, but we'll need to make sure to parse it first. For AC_STRING, we'll likely have to initialize our vendor (and maybe system?) fields anew.

Also, add validation for format of fides_string. We accept TC, TC, and TC,AC, but let's reject ,AC.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

https://ethyca.atlassian.net/wiki/spaces/PM/pages/2784788587

@eastandwestwind
Copy link
Contributor

Let's think about: when a custom fides_tc_string is passed in, what are the possible states? TC, TC,AC? It won’t be possible to just have AC or ,AC correct?

@NevilleS
Copy link
Contributor

Yeah- just TC, TC, and TC,AC

We can reject ,AC, that's invalid because the core TC string is always needed for a complete signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants