-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1117 Support and implement additional configs through Fides.init() #4262
Conversation
Passing run #4669 ↗︎
Details:
Review all test suite changes for PR #4262 ↗︎ |
47869d7
to
8d23a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whew, nice work @eastandwestwind , lots of new features here! left some comments, but I don't think any of them are that big!
9ac7397
to
4310e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job @eastandwestwind !! I think it's looking good—I added a discussion question which might be worth thinking about, but it doesn't necessarily block this PR.
also, I think this PR also closes #4265 but can you confirm? if it does, go ahead and assign it to yourself :)
91a1319
to
ba694d5
Compare
0641057
to
ce86814
Compare
Closes https://github.com/ethyca/fidesplus/issues/1117
Description Of Changes
Adds support for new config options, using Fides.init(), for exaxmple:
Details:
fides_embed
boolean config option. If this option is true, we "embed" the fides.js overlay UI (ie. “Layer 2”) into a web page instead of as a pop-up overlay, and never render the banner (ie. “Layer 1”). That page will be loaded in either the website or via a native app webview for managing privacy preferences instead of in a pop-up overlay. Use<div id="fides-embed-container"></div>
as the parent DOM node for the embedded overlay.fides_disable_save_api
boolean config option. If this option is true, we should disable the save to API, but still trigger the FidesUpdated event and save preferences to the cookie.fides_string
config option. If it's set,fides_tc_string
should supercede the cookie and any experience preferences, whether pre-fetched or client-side fetched. Importantly, if thefides_tc_string
does not define a preference for a given consent item, but theexperience
defines it, then we set the preference for that item to use thedefault_preference
fromexperience
Code Changes
Steps to Confirm
consent-banner-tcf.cy.ts
andconsent-banner.cy.ts
Pre-Merge Checklist
CHANGELOG.md