Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple versions of Python #1080

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
607708d
Prevent modifying default taxonomy fields (#990)
allisonking Aug 25, 2022
72642cf
Delete taxonomy UI (#1006)
allisonking Aug 25, 2022
1d7b896
Update cypress fixtures (#1022)
allisonking Aug 26, 2022
ba09cec
Add taxonomy entity form (#1019)
allisonking Aug 26, 2022
362fac9
Add check for is_default before rendering delete button (#1023)
allisonking Aug 30, 2022
0079c9e
Fix mypy error (#1030)
sanders41 Aug 31, 2022
343f045
Custom label for user defined taxonomy fields (#1027)
allisonking Aug 31, 2022
1ae809a
Add boolean fields and use them in taxonomy forms (#1028)
allisonking Aug 31, 2022
9aa7ac3
remove exclude_unset=True to return clean diff (#1026)
SteveDMurphy Sep 1, 2022
428267a
Set pydantic < 1.10.0 to fix CI issues with fideslang functions (#1045)
allisonking Sep 2, 2022
1eca516
[fidesctl-plus #78] cross app navigation (#1037)
ssangervasi Sep 2, 2022
d4961e1
1.8.3 (#1050)
allisonking Sep 6, 2022
183b2f1
noxfiles: Session for building fidesctl python package (#1047)
ssangervasi Sep 6, 2022
bd587a2
[942] fctl/api: Serve static files using route maps (#1046)
ssangervasi Sep 6, 2022
add237c
Fix truncated evaluation error messages (#1053)
ThomasLaPiana Sep 7, 2022
b15b5ed
Bump next-auth from 4.9.0 to 4.10.3 in /clients/ctl/admin-ui (#1025)
dependabot[bot] Sep 7, 2022
b9e127a
Cascade delete taxonomy children (#1042)
allisonking Sep 8, 2022
6352fd9
Initial systems management page (#1054)
allisonking Sep 9, 2022
aeabe68
1.8.4 (#1061)
SteveDMurphy Sep 9, 2022
3abc3c4
Alter taxonomy upsert behavior (#1040)
allisonking Sep 9, 2022
048b949
Remove disabled Nav Buttons (#1067)
ThomasLaPiana Sep 12, 2022
a2d88e5
Form to add a system via yaml (#1062)
allisonking Sep 12, 2022
5fdf922
ui/dataset: "Classify" toggle for fidesctl-plus (#1057)
ssangervasi Sep 12, 2022
74352b6
[1058] ui/dataset: Confirmation modal to kick off classify (#1069)
ssangervasi Sep 13, 2022
c9d1a13
Scaffold manual system flow (#1068)
allisonking Sep 14, 2022
dc8b6f3
[1073] ui/dataset: Show status badge for datasets using classificatio…
ssangervasi Sep 15, 2022
6dcb2a6
Test multiple versions of Python
ThomasLaPiana Sep 15, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,56 @@ The types of changes are:
* `Fixed` for any bug fixes.
* `Security` in case of vulnerabilities.

## [Unreleased](https://github.com/ethyca/fides/compare/1.8.2...main)
## [Unreleased](https://github.com/ethyca/fides/compare/1.8.4...main)

### Added

* Added more taxonomy fields that can be edited via the UI [#1000](https://github.com/ethyca/fides/pull/1000)
* Dataset generation enhancements using Fides Classify for Plus users:
* Added toggle for enabling classify during generation. [#1057](https://github.com/ethyca/fides/pull/1057)
* Initial implementation of API request to kick off classify, with confirmation modal. [#1069](https://github.com/ethyca/fides/pull/1069)
* Initial Classification & Review status for generated datasets. [#1074](https://github.com/ethyca/fides/pull/1074)
* New page to add a system via yaml [#1062](https://github.com/ethyca/fides/pull/1062)
* Skeleton of page to add a system manually [#1068](https://github.com/ethyca/fides/pull/1068)

### Changed

* Changed behavior of `load_default_taxonomy` to append instead of upsert [#1040](https://github.com/ethyca/fides/pull/1040)

## [1.8.4](https://github.com/ethyca/fides/compare/1.8.3...1.8.4) - 2022-09-09

### Added

* Initial system management page [#1054](https://github.com/ethyca/fides/pull/1054)

### Changed

* Deleting a taxonomy field with children will now cascade delete all of its children as well. [#1042](https://github.com/ethyca/fides/pull/1042)

### Fixed

* Fixed navigating directly to frontend routes loading index page instead of the correct static page for the route.
* Fix truncated evaluation error messages [#1053](https://github.com/ethyca/fides/pull/1053)

## [1.8.3](https://github.com/ethyca/fides/compare/1.8.2...1.8.3) - 2022-09-06

### Added

* Added more taxonomy fields that can be edited via the UI [#1000](https://github.com/ethyca/fides/pull/1000) [#1028](https://github.com/ethyca/fides/pull/1028)
* Added the ability to add taxonomy fields via the UI [#1019](https://github.com/ethyca/fides/pull/1019)
* Added the ability to delete taxonomy fields via the UI [#1006](https://github.com/ethyca/fides/pull/1006)
* Only non-default taxonomy entities can be deleted [#1023](https://github.com/ethyca/fides/pull/1023)
* Prevent deleting taxonomy `is_default` fields and from adding `is_default=True` fields via the API [#990](https://github.com/ethyca/fides/pull/990).
* Added a "Custom" tag to distinguish user defined taxonomy fields from default taxonomy fields in the UI [#1027](https://github.com/ethyca/fides/pull/1027)
* Added initial support for enabling Fides Plus [#1037](https://github.com/ethyca/fides/pull/1037)
* The `useFeatures` hook can be used to check if `plus` is enabled.
* Navigating to/from the Data Map page is gated behind this feature.
* Plus endpoints are served from the private Plus image.

### Fixed

* Fixed failing mypy tests [#1030](https://github.com/ethyca/fides/pull/1030)
* Fixed an issue where `fides push --diff` would return a false positive diff [#1026](https://github.com/ethyca/fides/pull/1026)
* Pinned pydantic version to < 1.10.0 to fix an error in finding referenced fides keys [#1045](https://github.com/ethyca/fides/pull/1045)

## [1.8.2](https://github.com/ethyca/fides/compare/1.8.1...1.8.2) - 2022-08-18

Expand Down
2 changes: 2 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ RUN : \
## Python Dependencies ##
#########################

# Install multiple versions of Python

COPY dev-requirements.txt dev-requirements.txt
RUN pip install -r dev-requirements.txt

Expand Down
103 changes: 103 additions & 0 deletions clients/ctl/admin-ui/__tests__/features/common/zones/config.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
import { configureZones, resolveZone } from "~/features/common/zones";

describe("resolveZone", () => {
// Allow mocking and resetting the node env in this test suite.
const env = process.env as { NODE_ENV: string };
afterEach(() => {
env.NODE_ENV = "test";
});

const config = configureZones({
development: {
host: "localhost:3000",
},

zones: [
{
basePath: "/datamap",
development: {
host: "localhost:4000",
},
},
{
basePath: "/no/dev",
},
],
});

describe("Within the root zone", () => {
const basePath = "/";

it("Does not modify a link within the root zone", () => {
env.NODE_ENV = "development";

const link = resolveZone({ config, basePath, href: "/root/route" });
expect(link).toMatchObject({
href: "/root/route",
basePath: "/",
});
});

it("Links to the dev host of another zone", () => {
env.NODE_ENV = "development";

const link = resolveZone({ config, basePath, href: "/datamap" });
expect(link).toMatchObject({
href: "http://localhost:4000/datamap",
basePath: "/datamap",
});
});

it("Does not link to the dev host in production", () => {
env.NODE_ENV = "production";

const link = resolveZone({ config, basePath, href: "/datamap" });
expect(link).toMatchObject({
href: "/datamap",
basePath: "/datamap",
});
});

it("Does not link to the dev host if none is configured", () => {
env.NODE_ENV = "development";

const link = resolveZone({ config, basePath, href: "/no/dev" });
expect(link).toMatchObject({
href: "/no/dev",
basePath: "/no/dev",
});
});
});

describe("Within a sub zone", () => {
const basePath = "/datamap";

it("Strips the base path of the sub-zone", () => {
const link = resolveZone({ config, basePath, href: "/datamap/route" });
expect(link).toMatchObject({
href: "/route",
basePath: "/datamap",
});
});

it("Links to the dev host of the root zone", () => {
env.NODE_ENV = "development";

const link = resolveZone({ config, basePath, href: "/root/route" });
expect(link).toMatchObject({
href: "http://localhost:3000/root/route",
basePath: "/",
});
});

it("Does not link to the dev host in production", () => {
env.NODE_ENV = "production";

const link = resolveZone({ config, basePath, href: "/root/route" });
expect(link).toMatchObject({
href: "/root/route",
basePath: "/",
});
});
});
});
23 changes: 0 additions & 23 deletions clients/ctl/admin-ui/__tests__/features/system.test.tsx

This file was deleted.

18 changes: 18 additions & 0 deletions clients/ctl/admin-ui/__tests__/features/taxonomy-helpers.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { parentKeyFromFidesKey } from "~/features/taxonomy/helpers";

describe("taxonomy helpers", () => {
describe("parent key from fides key", () => {
it("should handle nested fides keys", () => {
const fidesKey = "grandparent.parent.child";
expect(parentKeyFromFidesKey(fidesKey)).toEqual("grandparent.parent");
});
it("should handle empty fides key", () => {
const fidesKey = "";
expect(parentKeyFromFidesKey(fidesKey)).toEqual("");
});
it("should handle single fides key", () => {
const fidesKey = "root";
expect(parentKeyFromFidesKey(fidesKey)).toEqual("");
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,19 @@ describe("data category transform", () => {
description: "Account's city level address data.",
label: "Account City",
value: "account.contact.city",
is_default: true,
},
],
description: "Contact data related to a system account.",
label: "Account Contact Data",
value: "account.contact",
is_default: true,
},
],
description: "Data related to a system account.",
label: "Account Data",
value: "account",
is_default: true,
},
{
children: [
Expand All @@ -32,11 +35,13 @@ describe("data category transform", () => {
description: "Data used to manage access to the system.",
label: "Authentication Data",
value: "system.authentication",
is_default: true,
},
],
description: "Data unique to, and under control of the system.",
label: "System Data",
value: "system",
is_default: true,
},
{
children: [
Expand All @@ -46,6 +51,7 @@ describe("data category transform", () => {
"Data derived from user provided data or as a result of user actions in the system.",
label: "Derived Data",
value: "user.derived",
is_default: true,
},
{
children: [
Expand All @@ -55,6 +61,7 @@ describe("data category transform", () => {
"Data provided or created directly by a user that is not identifiable.",
label: "User Provided Non-Identifiable Data",
value: "user.provided.nonidentifiable",
is_default: true,
},
{
children: [
Expand All @@ -63,31 +70,36 @@ describe("data category transform", () => {
description: "Age range data.",
label: "User Provided Non-Specific Age",
value: "user.provided.identifiable.non_specific_age",
is_default: true,
},
{
children: [],
description:
"Data related to the individual's political opinions.",
label: "Political Opinion",
value: "user.provided.identifiable.political_opinion",
is_default: true,
},
],
description:
"Data provided or created directly by a user that is linked to or identifies a user.",
label: "User Provided Identifiable Data",
value: "user.provided.identifiable",
is_default: true,
},
],
description:
"Data provided or created directly by a user of the system.",
label: "User Provided Data",
value: "user.provided",
is_default: true,
},
],
description:
"Data related to the user of the system, either provided directly or derived based on their usage.",
label: "User Data",
value: "user",
is_default: true,
},
]);
});
Expand All @@ -100,20 +112,23 @@ describe("data category transform", () => {
value: "anonymous_user",
description:
"An individual that is unidentifiable to the systems. Note - This should only be applied to truly anonymous users where there is no risk of re-identification",
is_default: true,
children: [],
},
{
label: "Citizen Voter",
value: "citizen_voter",
description:
"An individual registered to voter with a state or authority.",
is_default: true,
children: [],
},
{
label: "Commuter",
value: "commuter",
description:
"An individual that is traveling or transiting in the context of location tracking.",
is_default: true,
children: [],
},
]);
Expand Down
33 changes: 0 additions & 33 deletions clients/ctl/admin-ui/__tests__/nav.test.tsx

This file was deleted.

Loading