Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Privacy Center to the default development build #1262

Merged
merged 12 commits into from
Oct 6, 2022
Merged

Add Privacy Center to the default development build #1262

merged 12 commits into from
Oct 6, 2022

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Oct 6, 2022 •
edited
Loading

Closes #1164
Closes #1141

Code Changes

  • Improve the privacy center Dockerfile
  • Add pc as an optional arg to nox commands: nox -s dev -- pc, nox -s build -- pc
  • Add new configuration options for the privacy center: server_url_development and server_url_production
  • Maintain backwards compatibility for previous config: fidesops_host_development and fidesops_host_production

Note that I ended up using git cherry-pick to grab commits from #1145, which this PR replaces.

Steps to Confirm

  • Ran nox -s dev -- pc and confirmed that privacy center loaded at http://localhost:3001 (after a long build delay!)
  • Ran nox -s quickstart and confirmed that the privacy center can be used to submit a request for [email protected] (once Step Three has completed)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

This makes the privacy center a "first-class" service in the build, whereas historically it's only been developed with using npm commands in the sub-directory. It's still a bit slow to build and could use additional TLC, but this is a big improvement.

ThomasLaPiana and others added 10 commits October 6, 2022 13:37
@ThomasLaPiana @NevilleS
Update docker_nox.py
cd06501
@ThomasLaPiana @NevilleS
add a build command to the privacy center
92650c4
@ThomasLaPiana @NevilleS
add the privacy center to the compose file
410a6e4
@ThomasLaPiana @NevilleS
add the privacy center as a posarg for nox to spin up
a1d9e36
@ThomasLaPiana @NevilleS
remove volume from compose file and prettify the dockerfile for the p…
b287b88 
…rivacy center
@ThomasLaPiana @NevilleS
try to remove .next from .gitignore
c1ab854
@NevilleS
Fix startup
522db3e
@NevilleS
Fix nox command for privacy center, update config
cc949c8 
This fixes `nox -s dev -- pc` to run the "built" privacy center via
docker compose, which just required mounting a config.json. This is
still a bit messy but this will work for both development & production
uses.

While doing this, I also renamed the config variables for the PC to not
reference "fidesops" explicitly, while maintaining backwards
compatibility.
@NevilleS
Fix formatting
4d4e9d3
@NevilleS
Update PC defaults to use quickstart settings
8a249bd
@NevilleS NevilleS requested review from a team October 6, 2022 18:15
TheAndrewJackson
TheAndrewJackson suggested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit with the mock config.json otherwise it looks great. It like npm run format needs to be ran to pass the privacy center lint.

clients/ops/privacy-center/config/__mocks__/config.json Outdated Show resolved Hide resolved
clients/ops/privacy-center/constants/index.ts Show resolved Hide resolved
@NevilleS NevilleS mentioned this pull request Oct 6, 2022
Closed
TheAndrewJackson
TheAndrewJackson approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think everything is ready barring passing CI

@NevilleS
Copy link
Contributor Author

NevilleS commented Oct 6, 2022

Great, thanks @TheAndrewJackson 👍

@NevilleS NevilleS merged commit ea2b853 into main Oct 6, 2022
@NevilleS NevilleS deleted the ns-update-privacy-center branch October 6, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unified Fides] Can not submit through the PC Add a command to spin up the privacy center
3 participants
@NevilleS @TheAndrewJackson @ThomasLaPiana