Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update privacy request workflow docs #1490

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Update privacy request workflow docs #1490

merged 4 commits into from
Nov 2, 2022

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Oct 19, 2022 •
edited
Loading

Closes #1258

Code Changes

  • Updated instances of Fidesops -> Fides, clarified workflow docs.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@conceptualshark conceptualshark requested a review from a team October 19, 2022 13:34
@conceptualshark conceptualshark changed the title Cg dsr workflow docs Update privacy request workflow docs Oct 19, 2022
pattisdr
pattisdr approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, I see some phrasing improvements and Fidesops->Fides changes. The original issue references files not being found, was that all sorted out elsewhere?

@conceptualshark
Copy link
Contributor Author

@pattisdr All the broken links were fixed previously, so this is just some cleanup! I resolved the merge conflicts so this should be good to go.

pattisdr
pattisdr approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Cole looks good

@conceptualshark conceptualshark merged commit 3dab2a1 into main Nov 2, 2022
@conceptualshark conceptualshark deleted the cg-dsr-workflow-docs branch November 2, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattisdr pattisdr pattisdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs are referencing files that aren't present
2 participants
@conceptualshark @pattisdr