Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start index of privacy declarations #1649

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Nov 1, 2022

Closes #1648

Code Changes

  • Fixes the start index of privacy declarations

Steps to Confirm

  • Follow the repro steps in the bug ticket and confirm it doesn't happen anymore

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

I think this is the change needed, but I'm not sure if other things might be affected. for instance, I would expect since we started too early before (at index 6, system_dependencies), we would've ended too early (before data_qualifier). but it doesn't look like data_qualifier is part of the output so maybe I'm missing something.

@allisonking allisonking marked this pull request as ready for review November 1, 2022 16:49
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the bug is now fixed! It was being pushed down into the same position as system.privacy_declaration.data_qualifier. The number of fields is the same but the insertion point was just off by 1 - thanks and my apologies @allisonking

@allisonking allisonking merged commit 0fe77a2 into main Nov 1, 2022
@allisonking allisonking deleted the aking/1648/fix-na-system-dependencies branch November 1, 2022 19:46
SteveDMurphy pushed a commit that referenced this pull request Nov 1, 2022
* Fix start index of privacy declarations

* [skip ci] Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datamap endpoint system_dependencies are being overwritten by N/A when there are no privacy declarations
2 participants