Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate fastapi-caching and pin version #1765

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Nov 14, 2022

Closes

Code Changes

  • fastapi-caching was included in the dependencies twice so I removed the duplicate
  • All other dependencies have the version pinned but fastapi_caching did no so I pinned the version

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@sanders41 sanders41 self-assigned this Nov 15, 2022
@sanders41 sanders41 added bug Something isn't working dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Nov 15, 2022
@sanders41 sanders41 merged commit 990c15b into main Dec 6, 2022
@sanders41 sanders41 deleted the double-dependency branch December 6, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants