-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send email alerts on privacy request failures #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this so far @sanders41 !
Just have a couple requests / questions.
In addition, do we have another ticket to add docs for configuring these privacy request notifications?
src/fides/api/ops/api/v1/endpoints/privacy_request_endpoints.py
Outdated
Show resolved
Hide resolved
src/fides/api/ops/email_templates/templates/privacy_request_error_notification.html
Outdated
Show resolved
Hide resolved
src/fides/api/ops/service/messaging/message_dispatch_service.py
Outdated
Show resolved
Hide resolved
@eastandwestwind ready for another review.
Good question. I haven't seen a ticket for this so I created one here #1997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making those changes, looks good to me!
Closes #1493
Code Changes
Steps to Confirm
privacy-request/notification
route to add an email address to receive notifications and set the notification threshold.Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats