Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable the config wizard but flag the stepper #1836

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Reenable the config wizard but flag the stepper #1836

merged 7 commits into from
Nov 22, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Nov 21, 2022 •
edited
Loading

Closes #1825

Code Changes

Steps to Confirm

  • Should be able to click "Add Systems" in the nav bar and enter the config wizard flow, but without the stepper showing

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Screen.Recording.2022-11-21.at.4.45.52.PM.mov

@allisonking
Copy link
Contributor Author

allisonking commented Nov 21, 2022 •
edited
Loading

okta tests are failing unrelated to this PR except that this PR makes it visible in CI since the cypress test has been reenabled. captured here: #1837

@allisonking
Fix bug in getRedirectRoute
b052cde 
We need to return undefined if the systems are still loading so that we don't get redirected right away.
@allisonking allisonking marked this pull request as ready for review November 22, 2022 14:06
LKCSmith
LKCSmith approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Like the new name for the route as well 👍

@allisonking allisonking mentioned this pull request Nov 22, 2022
Merged
12 tasks
@allisonking allisonking merged commit c0b5687 into main Nov 22, 2022
@allisonking allisonking deleted the aking/1825/reenable-config-wizard branch November 22, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKCSmith LKCSmith LKCSmith approved these changes

@ssangervasi ssangervasi Awaiting requested review from ssangervasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable config wizard with some caveats
2 participants
@allisonking @LKCSmith