Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/nav: Nav 2.0: Top Bar, Side Bar, and configuration for groups #2047

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Dec 15, 2022

Closes #1909

Code Changes

  • Installed latest fidesui components
  • Gated Nav 2.0 behind a features.slice flag.
  • NavTopBar, NavSideBar, and link components that use primary/secondary styling accordingly.
  • nav/v2/nav-config contains the logic for including/excluding:
    • Plus links
    • Groups that requires DSR Connections
    • Groups that require Systems.
    • Unit tests!

Steps to Confirm

  • Fides (OSS) server
    • First-time user (initial setup)
      1. Only "Home" and "Management" should show in the header
      2. Until New Fides Home page #1864 is merged, "Home" is still privacy requests
      3. Clicking on Management navigates to the taxonomy page
      4. A sidebar shows taxonomy active and has a link to user management
    • Returning user
      1. If there are systems, "Data map" shows in the top nav.
      2. Clicking "Data map" navigates to the systems list
      3. If there are DSR connections, "Privacy requests" shows in the top nav.
      4. Until New Fides Home page #1864 is merged, "Privacy requests" is a 404
  • Fidesplus server
    • First-time user (initial setup)
      1. Nav behaves the same as OSS.
    • Returning user
      1. If there are systems, "Data map" shows in the top nav.
      2. Clicking "Data map" navigates to the visual data map
      3. The side nav for "Data map" allows navigating to systems and datasets
      4. Privacy requests behave the same as OSS

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

"First time" user:
first-timer

With fidesplus server running:
https://user-images.githubusercontent.com/2236777/207749867-78c76a6e-7122-4e80-ade0-2ec142d55bc9.mp4
(Note that I don't have any DSRs defined, and I don't have the new homepage yet)

Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥇

@ssangervasi ssangervasi force-pushed the ssangervasi/fides-1909/nav-2-0-nav-components branch from b9c2269 to a251eea Compare December 16, 2022 00:03
@ssangervasi ssangervasi force-pushed the ssangervasi/fides-1909/nav-2-0-nav-components branch from a251eea to 0f70451 Compare December 16, 2022 17:52
@ssangervasi ssangervasi merged commit fe4f121 into main Dec 16, 2022
@ssangervasi ssangervasi deleted the ssangervasi/fides-1909/nav-2-0-nav-components branch December 16, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation for Fides 2.0 - fides implementation
2 participants