Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove next-auth from privacy center to fix JS console error #2090

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Remove next-auth from privacy center to fix JS console error #2090

merged 3 commits into from
Dec 23, 2022

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Dec 20, 2022 •
edited
Loading

Code Changes

  • Remove next-auth

Steps to Confirm

  • Run nox -s test_env and open the developer console

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Something that has been bothering me for awhile is that the Privacy Center always renders some errors like so:
image

After a quick look I realized this was just some dead code from the unused next-auth library, which was an easy fix.

@NevilleS NevilleS merged commit f384960 into main Dec 23, 2022
@NevilleS NevilleS deleted the ns-remove-next-auth branch December 23, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssangervasi ssangervasi ssangervasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NevilleS @ssangervasi