Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nav link to /classify-systems #2128

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Add nav link to /classify-systems #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5444e6a
Add nav link to /classify-systems
allisonking Jan 4, 2023
1a551a0
Fix unit test
allisonking Jan 4, 2023
dee4356
Update changelog
allisonking Jan 4, 2023
d2bb053
Merge branch 'main' into aking/fidesplus-473/nav-classify-systems
allisonking Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The types of changes are:

* Added the connection key to the execution log [#2100](https://github.com/ethyca/fides/pull/2100)
* Added endpoints to retrieve DSR `Rule`s and `Rule Target`s [#2116](https://github.com/ethyca/fides/pull/2116)
* Add link to Classify Systems page in nav side bar [#2128](https://github.com/ethyca/fides/pull/2128)
* Dataset classification UI now polls for results [#2123](https://github.com/ethyca/fides/pull/2123)

### Changed
Expand Down
1 change: 1 addition & 0 deletions clients/admin-ui/src/features/common/nav/v2/nav-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ describe("configureNavGroups", () => {
{ title: "View systems", path: "/system" },
{ title: "Add systems", path: "/add-systems" },
{ title: "Manage datasets", path: "/dataset" },
{ title: "Classify systems", path: "/classify-systems" },
],
});
});
Expand Down
5 changes: 5 additions & 0 deletions clients/admin-ui/src/features/common/nav/v2/nav-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ export const NAV_CONFIG: NavConfigGroup[] = [
{ title: "View systems", path: "/system" },
{ title: "Add systems", path: "/add-systems" },
{ title: "Manage datasets", path: "/dataset" },
{
title: "Classify systems",
path: "/classify-systems",
requiresPlus: true,
},
],
},
{
Expand Down