-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset UI Adjustments #2149
Dataset UI Adjustments #2149
Conversation
…splus490-ux-changes
Pushing this up and planning to ask for help around how to manage the state so the navigation back works as well. Additionally, the toast message loads twice. This commit attempts to move the `handleLoadDataset` function call to be done on page load if there is an `activeDatasetFidesKey` (essentially what happened on the button click) however I think I am getting lost in some of the state management with dispatch calls from DatasetTable.tsx
@allisonking or @TheAndrewJackson would love any insight or direction you may have on where I have gone wrong with removing the load dataset button in 8e025bb 😬 Tried to record my screen with it but essentially I was trying to move the Screen.Recording.2023-01-09.at.5.22.31.PM.mov |
By breaking out the `handleLoadataset` functionality and moving it upstream into the `handleRowClick` we are able to remove the need for the load dataset button. Co-authored-by: Allison King <[email protected]>
@allisonking and @rsilvery here is a loom video of the changes as well -> https://www.loom.com/share/266cecc6f5f349e18472afd3d87a1f08 |
Co-authored-by: Allison King <[email protected]>
…splus490-ux-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job figuring out all the redux/cypress!! these are great improvements 💯
Closes fidesplus#490
Code Changes (listed by commit)
For
http://localhost:8080/dataset/new
manually generate a dataset
Connect to a database
Classify dataset
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
These are just some of the simpler changes, the remaining changes more aligned with classify
maywill end up split out to a separate PR for size reasons