Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing custom request overrides in main.py #2186

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Importing custom request overrides in main.py #2186

merged 3 commits into from
Jan 10, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jan 10, 2023

Closes #2185

Code Changes

  • Importing custom request overrides in main.py

Steps to Confirm

  • Run nox -s dev and inspect the logs, you should see Registering new SaaS request override function...

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue Jan 10, 2023 that may be closed by this pull request
Custom request overrides are not loaded on server startup #2185
Closed
@galvana galvana marked this pull request as ready for review January 10, 2023 07:00
@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Jan 10, 2023
adamsachs
adamsachs approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i'll merge to get this into main asap

@adamsachs adamsachs merged commit c57d920 into main Jan 10, 2023
@adamsachs adamsachs deleted the 2185-custom-request-overrides-are-not-loaded-on-server-startup branch January 10, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom request overrides are not loaded on server startup
2 participants
@galvana @adamsachs