Fix Cookie House purchase modal flashing 'Error' in title #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2138
Code Changes
product.namefrom title with static "Submit Your Order" text insteadSteps to Confirm
nox -s "build(sample)"to rebuild projectfides deploy up --no-pullto run sample projectPre-Merge Checklist
CHANGELOG.mdDescription Of Changes
This is a subtle one - but technically the
productprop is only valid for this modal until the purchase is made, so when the modal is fading out the "Error" text would display. Rather than fight with some additional state here, the safest change is to just not render a dynamic title on the modal.See quick video here:
https://www.loom.com/share/a050cfa7cce14d42b7f01d1086481ff1
...and updated screenshot:
