Rename user_id --> ga_client_id
#2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattisdr
approved these changes
Jan 24, 2023
8 tasks
pattisdr
reviewed
Jan 24, 2023
| @@ -767,7 +767,7 @@ class ProvidedIdentityType(EnumType): | |||
|
|
|||
| email = "email" | |||
| phone_number = "phone_number" | |||
| user_id = "user_id" | |||
| ga_client_id = "ga_client_id" | |||
There was a problem hiding this comment.
one more question, are we sure that it is the client_id and not the app_instance_id?
My options in the API request are:
Type of user. One of APP_INSTANCE_ID, CLIENT_ID or USER_ID.
There was a problem hiding this comment.
oh! I know that the cookie only has the client_id. I'm guessing the app_instance_id might be the GA value customers have to put in their javascript, but let me take a look at the docs and get back to you.
There was a problem hiding this comment.
okay yes, looking at this, https://developers.google.com/analytics/devguides/config/userdeletion/v3, it should be client_id we want here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches up #2304 after some more conversation with @pattisdr
Code Changes
user_idtoga_client_id. Since this was merged to a feature branch, should be safe to make these changes directly instead of making another alembic migrationSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
Will also need to update #2337