Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to codecov #2402

Merged
merged 17 commits into from
Jan 27, 2023
Merged

Switch to codecov #2402

merged 17 commits into from
Jan 27, 2023

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jan 27, 2023

Closes #2181, #2182, #2183

Code Changes

  • Switch code climate to codecov
  • Changed README coverage badge to codecov

Steps to Confirm

  • The codecov comment shows no coverage because it uses main as the baseline for change in coverage, and because there has been no run on main yet there is nothing to compare to. The coverage for this branch can be viewed at https://app.codecov.io/github/ethyca/fides/tree/ps-codecov
  • Make sure references to code climate on the README.md have been replaced with codecov

Pre-Merge Checklist

Description Of Changes

After #2342 and getting migrations excluded from coverage we are above the 85% coverage mark.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@159b235). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2402   +/-   ##
=======================================
  Coverage        ?   88.55%           
=======================================
  Files           ?      327           
  Lines           ?    15714           
  Branches        ?     4348           
=======================================
  Hits            ?    13915           
  Misses          ?     1644           
  Partials        ?      155           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

codecov.yaml Outdated Show resolved Hide resolved
codecov.yaml Outdated Show resolved Hide resolved
@sanders41 sanders41 marked this pull request as ready for review January 27, 2023 13:13
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there may be some remaining code climate items in constants.py lines 41-43, ci_nox.py lines 187-189, and all of fix_coverage.py

Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments around some lingering code climate items but this looks great!
Excited to see how it looks in PRs once we get some other things merged to main. Last thing might just be to add something to changelog.md as well (since we mention code climate in there too for the previous PR)

@sanders41
Copy link
Contributor Author

sanders41 commented Jan 27, 2023

Thanks @SteveDMurphy for finding the extra code climate spots I missed! 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage to 85%
2 participants