-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to codecov #2402
Switch to codecov #2402
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
=======================================
Coverage ? 88.55%
=======================================
Files ? 327
Lines ? 15714
Branches ? 4348
=======================================
Hits ? 13915
Misses ? 1644
Partials ? 155 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there may be some remaining code climate items in constants.py
lines 41-43, ci_nox.py
lines 187-189, and all of fix_coverage.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments around some lingering code climate items but this looks great!
Excited to see how it looks in PRs once we get some other things merged to main
. Last thing might just be to add something to changelog.md
as well (since we mention code climate in there too for the previous PR)
Thanks @SteveDMurphy for finding the extra code climate spots I missed! 🔍 |
Closes #2181, #2182, #2183
Code Changes
Steps to Confirm
main
as the baseline for change in coverage, and because there has been no run on main yet there is nothing to compare to. The coverage for this branch can be viewed at https://app.codecov.io/github/ethyca/fides/tree/ps-codecovREADME.md
have been replaced with codecovPre-Merge Checklist
CHANGELOG.md
Description Of Changes
After #2342 and getting migrations excluded from coverage we are above the 85% coverage mark.