Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSV export #2452

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Update CSV export #2452

merged 4 commits into from
Feb 1, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jan 31, 2023

Closes #2306

Code Changes

  • Add request ID to CSV export
  • Export the request action type instead of the policy key
  • Update CSV headers to match the table

Steps to Confirm

  • Run fides and export the privacy requests
  • Inspect csv and make sure in includes the privacy request id, the action type, and is in the correct order

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review January 31, 2023 20:34
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works a charm, thanks @TheAndrewJackson

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 88.42% // Head: 88.42% // No change to project coverage 👍

Coverage data is based on head (b7369f5) compared to base (32065f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2452   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files         327      327           
  Lines       15892    15892           
  Branches     4416     4416           
=======================================
  Hits        14053    14053           
  Misses       1685     1685           
  Partials      154      154           
Impacted Files Coverage Δ
.../ops/api/v1/endpoints/privacy_request_endpoints.py 91.84% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheAndrewJackson TheAndrewJackson merged commit 8d9aeb2 into main Feb 1, 2023
@TheAndrewJackson TheAndrewJackson deleted the bugfix_2306_ID_in_csv branch February 1, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Request Type and Request ID fields to the privacy requests CSV download
3 participants