Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomer connector and tests #2520

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Kustomer connector and tests #2520

merged 6 commits into from
Feb 23, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Feb 6, 2023

Closes #1870

Code Changes

  • Access and erasure support for Kustomer
    • customer (read and erase)
  • Can initiate traversal using email or phone number

Steps to Confirm

  • Created integration tests to verify access and erasure

Pre-Review Checklist

  • Postman collections are up-to-date
  • Test credentials have been added to 1password
  • The new tests for this connector pass locally

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 86.37% // Head: 86.23% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (5f648ad) compared to base (3b8ff72).
Patch has no changes to coverable lines.

❗ Current head 5f648ad differs from pull request most recent head 7d8563f. Consider uploading reports for the commit 7d8563f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
- Coverage   86.37%   86.23%   -0.15%     
==========================================
  Files         289      289              
  Lines       15998    15796     -202     
  Branches     2017     1986      -31     
==========================================
- Hits        13819    13622     -197     
+ Misses       1790     1786       -4     
+ Partials      389      388       -1     
Impacted Files Coverage Δ
src/fides/api/ops/models/application_config.py 94.11% <0.00%> (-5.89%) ⬇️
...es/api/ops/api/v1/endpoints/messaging_endpoints.py 87.64% <0.00%> (-5.05%) ⬇️
src/fides/api/ops/util/cache.py 90.78% <0.00%> (-3.18%) ⬇️
src/fides/api/ops/models/messaging.py 87.93% <0.00%> (-2.98%) ⬇️
src/fides/api/ops/api/deps.py 96.15% <0.00%> (-0.52%) ⬇️
src/fides/core/config/__init__.py 89.28% <0.00%> (-0.49%) ⬇️
.../ops/service/messaging/message_dispatch_service.py 59.70% <0.00%> (-0.39%) ⬇️
.../service/privacy_request/request_runner_service.py 77.06% <0.00%> (-0.18%) ⬇️
...rc/fides/api/ops/api/v1/endpoints/drp_endpoints.py 92.00% <0.00%> (-0.11%) ⬇️
src/fides/api/ops/models/privacy_request.py 95.87% <0.00%> (-0.09%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kelsey-Ethyca Kelsey-Ethyca marked this pull request as ready for review February 13, 2023 18:14
@galvana galvana changed the title Draft: kustomer connector and tests Kustomer connector and tests Feb 21, 2023
@cypress
Copy link

cypress bot commented Feb 21, 2023

Passing run #265 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5f648ad into 871ccf6...
Project: fides Commit: 16e5028336 ℹ️
Status: Passed Duration: 00:38 💡
Started: Feb 22, 2023 12:31 AM Ended: Feb 22, 2023 12:32 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana self-requested a review February 22, 2023 00:18
@galvana galvana merged commit a2336a3 into main Feb 23, 2023
@galvana galvana deleted the kt-kustomer-1870 branch February 23, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomer
3 participants