Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amplitude access and erasure request test #2552

Closed
wants to merge 2 commits into from

Conversation

tmuralikrishnan
Copy link
Contributor

@tmuralikrishnan tmuralikrishnan commented Feb 9, 2023

Closes #1945

Code Changes

NEW SaaS Connector Vend for access and erasure

Steps to Confirm

  • Add/configure the Jira connector in UI
  • Verify Jira config and icon UI looks good
  • Add customer data using Jira UI (no api to add sales)
  • Create an Access DSR with the new Jira customer email
  • Verify email sent by fides with customer data is correct
  • Create an Delete DSR with the new Jira customer email
  • Verify the customer data is now deleted in Jira

Pre-Merge Checklist

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access and Erasure Tests Passing
  • Icon

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 88.63% // Head: 88.66% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (eb9d13c) compared to base (0a3fa52).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
+ Coverage   88.63%   88.66%   +0.02%     
==========================================
  Files         331      331              
  Lines       16131    16095      -36     
  Branches     4485     4469      -16     
==========================================
- Hits        14298    14270      -28     
+ Misses       1676     1668       -8     
  Partials      157      157              
Impacted Files Coverage Δ
src/fides/lib/oauth/api/deps.py 92.85% <0.00%> (+2.38%) ⬆️
src/fides/lib/oauth/oauth_util.py 100.00% <0.00%> (+2.63%) ⬆️
src/fides/api/ops/util/oauth_util.py 93.00% <0.00%> (+6.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NevilleS NevilleS deleted the amplitude-access-muralikrishnan branch May 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amplitude
2 participants