Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Improvements #2566

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Logging Improvements #2566

merged 6 commits into from
Feb 16, 2023

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Feb 9, 2023

This PR contains some quality of life improvements around logging, especially at startup.

Closes #2488

Code Changes

  • Log Version at Startup
  • Change log level of initial startup messages to INFO from WARNING
  • Round handler_time to 3 decimal places to avoid weird rounding oddities like 'handler_time': '23.339000000000002ms'

Steps to Confirm

  • Startup Fides and review logs

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@RobertKeyser RobertKeyser self-assigned this Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 86.26% // Head: 86.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e8700bc) compared to base (8d445e8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files         289      289           
  Lines       15823    15824    +1     
  Branches     1997     1997           
=======================================
+ Hits        13650    13651    +1     
  Misses       1785     1785           
  Partials      388      388           
Impacted Files Coverage Δ
src/fides/api/main.py 80.39% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise looks great to me!

@cypress
Copy link

cypress bot commented Feb 16, 2023

Passing run #172 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge e8700bc into 8d445e8...
Project: fides Commit: ddbc7939b8 ℹ️
Status: Passed Duration: 00:50 💡
Started: Feb 16, 2023 5:44 PM Ended: Feb 16, 2023 5:45 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@RobertKeyser RobertKeyser merged commit b100579 into main Feb 16, 2023
@RobertKeyser RobertKeyser deleted the rk-handler-time-rounding branch February 16, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Fides Version on Startup
2 participants