-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging Improvements #2566
Logging Improvements #2566
Conversation
Codecov ReportBase: 86.26% // Head: 86.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 289 289
Lines 15823 15824 +1
Branches 1997 1997
=======================================
+ Hits 13650 13651 +1
Misses 1785 1785
Partials 388 388
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise looks great to me!
Co-authored-by: Thomas <[email protected]>
Passing run #172 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
This PR contains some quality of life improvements around logging, especially at startup.
Closes #2488
Code Changes
INFO
fromWARNING
handler_time
to 3 decimal places to avoid weird rounding oddities like'handler_time': '23.339000000000002ms'
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats