Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplitude Connector #2569

Merged
merged 14 commits into from
May 2, 2023
Merged

Amplitude Connector #2569

merged 14 commits into from
May 2, 2023

Conversation

soundayra21
Copy link
Contributor

@soundayra21 soundayra21 commented Feb 10, 2023

Closes #1945

Code Changes

NEW SaaS Connector Amplitude for access and erasure

Steps to Confirm

  • Add/configure the Amplitude connector in UI
  • Verify Amplitude config and icon UI looks good
  • Add user data using Amplitude api
  • Create an Access DSR with the new Amplitude user email
  • Verify email sent by fides with user data is correct
  • Create an Delete DSR with the new Amplitude user email
  • Verify the user data is now deleted in Amplitude

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access and Erasure Tests Passing
  • Icon

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (177ad01) 87.41% compared to head (258bfdb) 87.39%.

❗ Current head 258bfdb differs from pull request most recent head a32db94. Consider uploading reports for the commit a32db94 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2569      +/-   ##
==========================================
- Coverage   87.41%   87.39%   -0.03%     
==========================================
  Files         306      306              
  Lines       17540    17598      +58     
  Branches     2255     2270      +15     
==========================================
+ Hits        15333    15379      +46     
- Misses       1793     1801       +8     
- Partials      414      418       +4     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soundayra21
Copy link
Contributor Author

soundayra21 commented Mar 3, 2023

image

image

@soundayra21
Copy link
Contributor Author

Post to deletion/users takes days to complete

@Kelsey-Ethyca Kelsey-Ethyca changed the title Tests for amplitude connector Amplitude Connector Mar 13, 2023
@cypress
Copy link

cypress bot commented Apr 13, 2023

Passing run #1702 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge a32db94 into 0b03e9f...
Project: fides Commit: 0a55c684f7 ℹ️
Status: Passed Duration: 01:04 💡
Started: May 2, 2023 7:49 PM Ended: May 2, 2023 7:50 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values used for authentication need to be updated to match the docs. Also make sure to update Postman and 1password with these values.

@galvana galvana dismissed their stale review May 2, 2023 22:54

Changes completed

@galvana galvana removed their request for review May 2, 2023 23:00
@galvana galvana merged commit 46c7f54 into main May 2, 2023
@galvana galvana deleted the amplitude-access-soundarya branch May 2, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amplitude
4 participants