-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds intake and storage of Global Privacy Control Signal props for Consent #2599
Conversation
9638be2
to
065d0f6
Compare
Passing run #290 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
b3288bd
to
c090f44
Compare
Codecov ReportBase: 86.22% // Head: 86.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
==========================================
+ Coverage 86.22% 86.24% +0.01%
==========================================
Files 289 289
Lines 15780 15800 +20
Branches 1985 1986 +1
==========================================
+ Hits 13607 13626 +19
- Misses 1785 1786 +1
Partials 388 388
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/fides/api/ctl/migrations/versions/d65bbc647083_adds_gpc_info_to_consent_table.py
Show resolved
Hide resolved
Co-authored-by: Paul Sanders <[email protected]>
I just testing locally and thing started without error. Going to try a restart on the tests here. Hopefully we aren't back to a CI only issue 😕 |
@sanders41 it's just the migration down rev that needed to be bumped. It's weird that this is the way it manifests in CI though. |
And that it doesn't happen locally. Very weird. |
❗ Contains a DB migration! Check for any conflicts before merging. ❗
Closes #2240
Code Changes
Consent
table to store 2 new columns pertaining to GPC:has_gpc_flag
andconflicts_with_gpc
Consent
schema to intake these 2 fields as optionalSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats