include feature flag check in helper

[SteveDMurphy]

Closes fidesplus#619

Code Changes

• Include feature flag in helper function

Steps to Confirm

• Tested that the classification details are visible on the data map after approval for both feature flag scenarios
  • Add a new system and privacy declaration
  • Validate the one line on the data map
  • Classify and approve a dataset (I used postgresql+psycopg2://postgres:fides@fidesplus-db:5432/fides)
  • Reference dataset in privacy declaration
  • View details on data map!
  • Delete and do it again with the feature flag flipped

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md

Description Of Changes

If the feature flag was enabled, the data would be visible on the data map. Adding the feature flag and not accounting for it in all areas is the root cause of the issue here

[cypress]

Passing run #357 ↗︎

0	3	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 03e7b51 into dd46f8f...
Project: fides	Commit: d7e3db7607 ℹ️
Status: Passed	Duration: 00:38 💡
Started: Feb 23, 2023 9:24 PM	Ended: Feb 23, 2023 9:25 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Base: 86.39% // Head: 86.46% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (03e7b51) compared to base (3b8ff72).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
+ Coverage   86.39%   86.46%   +0.06%     
==========================================
  Files         289      289              
  Lines       15998    15984      -14     
  Branches     2017     2026       +9     
==========================================
- Hits        13822    13820       -2     
+ Misses       1788     1779       -9     
+ Partials      388      385       -3     

Impacted Files	Coverage Δ
...ementations/friendbuy_nextgen_request_overrides.py	58.82% <0.00%> (-4.34%)	⬇️
src/fides/api/ops/analytics.py	53.12% <0.00%> (-1.43%)	⬇️
src/fides/api/ops/task/graph_task.py	93.41% <0.00%> (-1.07%)	⬇️
src/fides/api/ops/tasks/__init__.py	78.78% <0.00%> (-0.63%)	⬇️
...s/api/ops/service/connectors/fides/fides_client.py	78.12% <0.00%> (-0.45%)	⬇️
.../api/ops/util/encryption/hmac_encryption_scheme.py	90.47% <0.00%> (-0.44%)	⬇️
src/fides/api/ops/graph/analytics_events.py	83.78% <0.00%> (-0.43%)	⬇️
src/fides/api/ops/models/registration.py	85.29% <0.00%> (-0.43%)	⬇️
.../ops/service/messaging/message_dispatch_service.py	59.70% <0.00%> (-0.39%)	⬇️
src/fides/api/ctl/database/database.py	86.95% <0.00%> (-0.37%)	⬇️
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SteveDMurphy]

There is a failing cypress test but I think it is resolved in #2668

[allisonking]

confirmed it works! but also I think that dataset references field is being removed from the privacy declaration form soon... 😬

[SteveDMurphy]

confirmed it works! but also I think that dataset references field is being removed from the privacy declaration form soon... 😬

Really? Thanks for the heads up, will be interesting to see where it lands :)